Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sankey select error and improve handling of zero indexed subplots #6265

Merged
merged 5 commits into from
Jul 15, 2022
Merged

Fix sankey select error and improve handling of zero indexed subplots #6265

merged 5 commits into from
Jul 15, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 15, 2022

Fixes #6264.
Regression introduced in v2.13.0.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Jul 15, 2022
@archmoj archmoj changed the title Fix sankey select error on the first subplot indexed zero Fix sankey select error and improve handling of zero indexed subplots Jul 15, 2022
alexcjohnson
alexcjohnson approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@archmoj archmoj merged commit 4d1472a into master Jul 15, 2022
@archmoj archmoj deleted the fix-6264 branch July 15, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sankey select error
2 participants
@archmoj @alexcjohnson